fix attribute check for SQLAlchemy labeled column properties#5567
Merged
adhami3310 merged 1 commit intoJul 16, 2025
Conversation
CodSpeed Performance ReportMerging #5567 will not alter performanceComparing Summary
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Added a safety check for SQLAlchemy column nullable attribute access in reflex/utils/types.py to prevent AttributeError exceptions when handling special column types.
- Modified
get_attribute_access_typefunction to usehasattr()before accessingnullableattribute on SQLAlchemy columns - Improves handling of edge cases like hybrid properties and custom column types where
nullableattribute might not exist
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
adhami3310
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.